debconf1/.git
21 months ago modified: koha.postinst z3
buildbot [Thu, 10 Sep 2020 01:53:24 +0000 (13:53 +1200)]
modified:   koha.postinst

21 months ago modified: koha.config
buildbot [Thu, 10 Sep 2020 01:46:34 +0000 (13:46 +1200)]
modified:   koha.config
modified:   koha.postinst

21 months ago modified: koha.templates
buildbot [Wed, 9 Sep 2020 23:00:08 +0000 (11:00 +1200)]
modified:   koha.templates

21 months agoSigned-off-by: buildbot <buildbot@kohaaloha.com>
buildbot [Wed, 9 Sep 2020 22:50:09 +0000 (10:50 +1200)]
Signed-off-by: buildbot <buildbot@kohaaloha.com>
modified:   koha.postinst
new file:   koha.templates

21 months agoadd debconf
buildbot [Wed, 9 Sep 2020 19:15:29 +0000 (07:15 +1200)]
add debconf

Signed-off-by: buildbot <buildbot@kohaaloha.com>
modified:   koha.config

21 months agoSigned-off-by: buildbot <buildbot@kohaaloha.com>
buildbot [Wed, 9 Sep 2020 17:54:46 +0000 (05:54 +1200)]
Signed-off-by: buildbot <buildbot@kohaaloha.com>
deleted:    templates/koha-sites.conf

21 months agoSigned-off-by: buildbot <buildbot@kohaaloha.com>
buildbot [Wed, 9 Sep 2020 17:54:28 +0000 (05:54 +1200)]
Signed-off-by: buildbot <buildbot@kohaaloha.com>
modified:   control.in
deleted:    templates/koha-sites.conf

21 months agoSigned-off-by: buildbot <buildbot@kohaaloha.com>
buildbot [Wed, 9 Sep 2020 17:16:01 +0000 (05:16 +1200)]
Signed-off-by: buildbot <buildbot@kohaaloha.com>
new file:   templates.x1/koha-sites.conf

deleted:    templates/koha-sites.conf

21 months agoadd lib1
buildbot [Wed, 9 Sep 2020 17:02:57 +0000 (05:02 +1200)]
add lib1
modified:   koha.postinst

21 months agoSigned-off-by: buildbot <buildbot@kohaaloha.com>
buildbot [Wed, 9 Sep 2020 16:55:11 +0000 (04:55 +1200)]
Signed-off-by: buildbot <buildbot@kohaaloha.com>
modified:   koha.postinst

21 months agoadd deb.o1
buildbot [Wed, 9 Sep 2020 15:49:22 +0000 (03:49 +1200)]
add deb.o1

Signed-off-by: buildbot <buildbot@kohaaloha.com>
21 months agoSigned-off-by: buildbot <buildbot@kohaaloha.com>
buildbot [Wed, 9 Sep 2020 15:48:20 +0000 (03:48 +1200)]
Signed-off-by: buildbot <buildbot@kohaaloha.com>
new file:   koha.postinst.o1

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 13:13:03 +0000 (01:13 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agoSigned-off-by: buildbot <buildbot@kohaaloha.com>
buildbot [Wed, 9 Sep 2020 13:12:29 +0000 (01:12 +1200)]
Signed-off-by: buildbot <buildbot@kohaaloha.com>
modified:   rules

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 13:04:32 +0000 (01:04 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agoThu Sep 10 01:04:02 NZST 2020
buildbot [Wed, 9 Sep 2020 13:04:02 +0000 (01:04 +1200)]
Thu Sep 10 01:04:02 NZST 2020

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 13:01:54 +0000 (01:01 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 13:00:40 +0000 (01:00 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 12:56:31 +0000 (00:56 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agoThu Sep 10 00:56:00 NZST 2020
buildbot [Wed, 9 Sep 2020 12:56:00 +0000 (00:56 +1200)]
Thu Sep 10 00:56:00 NZST 2020

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 12:52:58 +0000 (00:52 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agoThu Sep 10 00:52:17 NZST 2020
buildbot [Wed, 9 Sep 2020 12:52:17 +0000 (00:52 +1200)]
Thu Sep 10 00:52:17 NZST 2020

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 12:49:20 +0000 (00:49 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months ago modified: koha.postinst
buildbot [Wed, 9 Sep 2020 12:48:28 +0000 (00:48 +1200)]
modified:   koha.postinst

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 12:32:45 +0000 (00:32 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 06:17:29 +0000 (18:17 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months ago modified: koha.install
buildbot [Wed, 9 Sep 2020 06:16:54 +0000 (18:16 +1200)]
modified:   koha.install
new file:   koha.install.o1

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 06:12:18 +0000 (18:12 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 06:02:46 +0000 (18:02 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:58:14 +0000 (16:58 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:57:03 +0000 (16:57 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:49:47 +0000 (16:49 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agorm scripts
buildbot [Wed, 9 Sep 2020 04:47:58 +0000 (16:47 +1200)]
rm scripts

Signed-off-by: buildbot <buildbot@kohaaloha.com>
21 months ago modified: debian/rules
buildbot [Wed, 9 Sep 2020 04:42:17 +0000 (16:42 +1200)]
modified:   debian/rules

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:42:04 +0000 (16:42 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:37:22 +0000 (16:37 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:32:04 +0000 (16:32 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agoSigned-off-by: buildbot <buildbot@kohaaloha.com>
buildbot [Wed, 9 Sep 2020 04:31:32 +0000 (16:31 +1200)]
Signed-off-by: buildbot <buildbot@kohaaloha.com>
new file:   Makefile.PL.o1

21 months ago deleted: Makefile.PL
buildbot [Wed, 9 Sep 2020 04:30:57 +0000 (16:30 +1200)]
deleted:    Makefile.PL

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:30:22 +0000 (16:30 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:16:36 +0000 (16:16 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months ago..
buildbot [Wed, 9 Sep 2020 04:16:00 +0000 (16:16 +1200)]
..
modified:   Makefile.PL

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Wed, 9 Sep 2020 04:10:59 +0000 (16:10 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agotrim
buildbot [Wed, 9 Sep 2020 04:10:17 +0000 (16:10 +1200)]
trim

modified:   Makefile.PL

21 months agorm t
buildbot [Tue, 8 Sep 2020 18:30:39 +0000 (06:30 +1200)]
rm t

Signed-off-by: buildbot <buildbot@kohaaloha.com>
21 months agoadd templates
Mason James [Tue, 8 Sep 2020 18:18:39 +0000 (06:18 +1200)]
add templates

Signed-off-by: Mason James <mtj@kohaaloha.com>
21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Tue, 8 Sep 2020 17:55:46 +0000 (05:55 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Tue, 8 Sep 2020 17:48:00 +0000 (05:48 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months ago modified: rules
Mason James [Tue, 8 Sep 2020 17:45:03 +0000 (05:45 +1200)]
modified:   rules

21 months agorm koha-common*
Mason James [Tue, 8 Sep 2020 17:39:36 +0000 (05:39 +1200)]
rm koha-common*

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Tue, 8 Sep 2020 17:27:07 +0000 (05:27 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Tue, 8 Sep 2020 17:19:20 +0000 (05:19 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agorm koha-common dep
Mason James [Tue, 8 Sep 2020 17:15:02 +0000 (05:15 +1200)]
rm koha-common dep
modified:   control
modified:   control.in

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Tue, 8 Sep 2020 17:08:10 +0000 (05:08 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agoadd verbose
Mason James [Tue, 8 Sep 2020 17:04:58 +0000 (05:04 +1200)]
add verbose

modified:   list-deps

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Tue, 8 Sep 2020 17:02:49 +0000 (05:02 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/control
buildbot [Tue, 8 Sep 2020 17:02:49 +0000 (05:02 +1200)]
buildbot 20.05.03 for stretch: update debian/control

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Tue, 8 Sep 2020 16:54:20 +0000 (04:54 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agorm koha-common
Mason James [Tue, 8 Sep 2020 16:53:26 +0000 (04:53 +1200)]
rm koha-common

modified:   control.in

21 months agorm non koha
Mason James [Tue, 8 Sep 2020 16:36:05 +0000 (04:36 +1200)]
rm non koha

modified:   control.in

21 months agobuildbot 20.05.03 for stretch: update debian/changelog
buildbot [Sat, 5 Sep 2020 14:29:23 +0000 (02:29 +1200)]
buildbot 20.05.03 for stretch: update debian/changelog

21 months agobuildbot 20.05.03 for stretch: update debian/control
buildbot [Sat, 5 Sep 2020 06:49:33 +0000 (18:49 +1200)]
buildbot 20.05.03 for stretch: update debian/control

21 months agoBug 26361: switch TableSettings to ColumnSettings
Lucas Gass [Thu, 3 Sep 2020 03:57:01 +0000 (03:57 +0000)]
Bug 26361: switch TableSettings to ColumnSettings

Test Plan:
-Be on 20.05.x
-Go to returns.tt
-See the error Uncaught SyntaxError: expected expression, got keyword 'var'.
-Apply patch
-Reload returns.tt, no error

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Mason James <mtj@kohaaloha.com>
21 months agoUpdate release notes for 20.05.03 release
Lucas Gass [Mon, 31 Aug 2020 21:03:41 +0000 (21:03 +0000)]
Update release notes for 20.05.03 release

21 months agoIncrement version for 20.05.03 release
Lucas Gass [Mon, 31 Aug 2020 20:59:45 +0000 (20:59 +0000)]
Increment version for 20.05.03 release

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
21 months agoTranslation updates for Koha 20.05.03
Koha translators [Mon, 24 Aug 2020 15:57:22 +0000 (12:57 -0300)]
Translation updates for Koha 20.05.03

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
21 months agoBug 26265: (QA follow-up) Remove g option from regex, add few dirs
Marcel de Rooy [Mon, 24 Aug 2020 08:03:48 +0000 (08:03 +0000)]
Bug 26265: (QA follow-up) Remove g option from regex, add few dirs

Adding .git. Using a regex.
If we make it a bit smarter, we do not need most dirs listed.

Test plan:
Run the test again

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 01bee142e6e0b997ddfb000a9623082b74bbe9ab)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 87570d81a28d043ba7c5111a64552e82974ca07e)

21 months agoBug 26265: Add test for missing directory in Makefile.PL
Jonathan Druart [Fri, 21 Aug 2020 13:09:44 +0000 (15:09 +0200)]
Bug 26265: Add test for missing directory in Makefile.PL

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 035ed3cee5f391fc90df53e537589dd702e056a8)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 5ea5f7f420d9772d4a632cd1b72b9ed1e35836c5)

21 months agoBug 26265: Add pos directory to the Makefile
Martin Renvoize [Fri, 21 Aug 2020 08:24:29 +0000 (09:24 +0100)]
Bug 26265: Add pos directory to the Makefile

This patch adds the /pos directory to the Makefile so that pos gets
properly mapped at make and install time.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit acbd6b72052381151f69a3b8aa70ab39cf4fda1c)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit b1e7e904867d5170f3052c1d93c72ab66da7be09)

21 months agoBug 26253: (bug 22857 follow-up) Remove duplicated mana_config in etc/koha-conf.xml
Jonathan Druart [Thu, 20 Aug 2020 08:10:14 +0000 (10:10 +0200)]
Bug 26253: (bug 22857 follow-up) Remove duplicated mana_config in etc/koha-conf.xml

It was there already but not at the same place!

Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit a4998b7d5758b0bee682fa7485d66390a3657a20)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 8305f582aafe348f5f2697fe5432e162989296b5)

21 months agoBug 26134: (bug 23463 follow-up) Fix add to basket from staged file
Jonathan Druart [Thu, 6 Aug 2020 10:50:36 +0000 (12:50 +0200)]
Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file

There is a ->store call missing when we attempt to create a new item.

Test plan:
- set at least one value in MARCItemFieldsToOrder
- add to a basket via staged file with at least one value matching your MARCItemFields mappings
- set required fields for your order and click Save
=> Without this patch you got:
receive error: "DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /kohadevbox/koha/Koha/Acquisition/Order.pm line 113
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77"
=> With this patch applied the order has been created successfully

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 12e1b2faccf6396d3c4b5327c881e78f177f135b)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 5e972d95ac834859ec5f9eabae0b2c20f7754818)

21 months agoBug 26162: Don't fall into an infinite loop
Jonathan Druart [Wed, 19 Aug 2020 05:19:09 +0000 (07:19 +0200)]
Bug 26162: Don't fall into an infinite loop

If something went wrong we do want to stop the script!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit a0b5cefdc88a3671a0310a90490be275bab46860)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit a29a9ec75408f135e070205fbd1868789b90b54b)

21 months agoBug 25360: (follow-up) Remove the https FIXME in Auth.pm
Marcel de Rooy [Wed, 5 Aug 2020 13:48:59 +0000 (13:48 +0000)]
Bug 25360: (follow-up) Remove the https FIXME in Auth.pm

The FIXME is no longer valid since we fixed the X-Forwarded headers
for Plack. And since we do not even use using_https anymore in
the templates (see bug 21094).

Test plan:
Run Auth.t
Git grep for using_https

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 5f6fb719bf6f6e6e0f830f97561ddc6e29012071)

21 months agoBug 25360: Use secure flag for CGISESSID cookie when using HTTPS
David Cook [Mon, 4 May 2020 01:12:26 +0000 (11:12 +1000)]
Bug 25360: Use secure flag for CGISESSID cookie when using HTTPS

This patch adds the secure flag to the CGISESSID cookie when using HTTPS.
This prevents the cookie being used again over a normal HTTP
request.

Bug 25360: [Follow-up] Test for "on" or "ON" value for HTTPS env var

This patch tests for HTTPS "on" or "ON" before setting the secure
cookie.

Bug 25360: [Follow-up] Fix typo in C4/InstallAuth.pm

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Amended number of tests in Context.t
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit c2a0b7a4e761b7d3bea9145440313e832808c60b)

21 months agoBug 24663: (follow-up) Remove authnotrequired if set to 0
Jonathan Druart [Mon, 2 Mar 2020 09:08:12 +0000 (10:08 +0100)]
Bug 24663: (follow-up) Remove authnotrequired if set to 0

2 newly added scripts

Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 12fc93f03a906317933dbd4dbbe63033e684840f)

21 months agoBug 24663: Handle special cases for recovery password and selfreg
Jonathan Druart [Mon, 17 Feb 2020 15:44:37 +0000 (16:44 +0100)]
Bug 24663: Handle special cases for recovery password and selfreg

The password recovery and self-registration features need to be
accessible at the OPAC even if not public.

Test plan:
Self register a new account, then ask for a new password with OpacPublic
turned off

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 5df7a3b6b589e692bec13a8f09258f2c26bfaa2c)

21 months agoBug 24663: Force authentication in svc/records/preview (?)
Jonathan Druart [Mon, 17 Feb 2020 12:31:38 +0000 (13:31 +0100)]
Bug 24663: Force authentication in svc/records/preview (?)

Was this wrong?

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f4bbeab8581b4abd926b14e4c2aed100598ec06e)

21 months agoBug 24663: Force auth in adveditorshortcuts.pl
Jonathan Druart [Mon, 17 Feb 2020 12:31:17 +0000 (13:31 +0100)]
Bug 24663: Force auth in adveditorshortcuts.pl

This was wrong!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 165c1c67613362a299138359e056f7b355d05c9e)

21 months agoBug 24663: Remove authnotrequired if set to 0
Jonathan Druart [Mon, 17 Feb 2020 12:20:48 +0000 (13:20 +0100)]
Bug 24663: Remove authnotrequired if set to 0

It defaults to 0 in get_template_and_user

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 79f7a3fc024323d8b4016d201a222118801bdcc6)

21 months agoBug 24663: Test OpacPublic for all OPAC scripts
Jonathan Druart [Mon, 17 Feb 2020 12:16:48 +0000 (13:16 +0100)]
Bug 24663: Test OpacPublic for all OPAC scripts

Prior to this patchset there were 3 different calls to
get_template_and_user (or checkauth) with the authnotrequired param:
 * authnotrequired => 0
 * authnotrequired => 1
 * authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 )

The first one says that an unauthenticated user can access the page, the
second that the user has to be authenticated, and the last one that it
depends on the OpacPublic syspref.
Actually we must replace the first one with the third one, if the OPAC
is not public, the authentication must be forced.

To do so we are going to remove the "authnotrequired => 0" occurrences,
and check the OpacPublic syspref's value in C4::Auth

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 1b095d1d80e5d4026a68e8df72ccd9918aff3dee)

21 months agoBug 23634: (QA follow-up) Our PUT is really a PATCH
Tomas Cohen Arazi [Mon, 13 Jul 2020 15:25:13 +0000 (12:25 -0300)]
Bug 23634: (QA follow-up) Our PUT is really a PATCH

This patch makes the controller not expect that there will always be all
the email fields. So it now checks if an email field was passed, and
changed, and renders the error if that stands.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests written by Nick highlight a problem
2. Apply this patch
3. Repeat 1
=> SUCCESS: Problems solved
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f58ae3f0ead21e77da038f37fa098593e50615d5)

21 months agoBug 23634: (QA follow-up) Adjust tests
Nick Clemens [Mon, 13 Jul 2020 10:33:11 +0000 (10:33 +0000)]
Bug 23634: (QA follow-up) Adjust tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 5ad5e09be0208290463a31ccb3be5b2be3a1082f)

21 months agoBug 23634: (QA follow-up) Catch all email cases in API
Martin Renvoize [Fri, 10 Jul 2020 08:38:31 +0000 (09:38 +0100)]
Bug 23634: (QA follow-up) Catch all email cases in API

The API was only catching the primary email change case, but we need to
catch email, emailpro and B_email.

We were also not accounting for any of the emails (on PUT or from the
DB) being undefined.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 31e362484bba5a42f218027cee0b15a714eccb8c)

21 months agoBug 23634: (follow-up) Prevent updates on POST
Martin Renvoize [Tue, 19 Nov 2019 16:59:06 +0000 (16:59 +0000)]
Bug 23634: (follow-up) Prevent updates on POST

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 3e213d65860ab4fcb6a425244729ac4a9fe8c19f)

21 months agoBug 23634: Secure the email on the API
Tomas Cohen Arazi [Tue, 19 Nov 2019 16:16:16 +0000 (13:16 -0300)]
Bug 23634: Secure the email on the API

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 624aa55ff33e6fe228ca806f8eb9c6592ab8cdbc)

21 months agoBug 23634: Prevent non-superlibrarians from editing superlibarian emails
Martin Renvoize [Tue, 19 Nov 2019 14:51:50 +0000 (14:51 +0000)]
Bug 23634: Prevent non-superlibrarians from editing superlibarian emails

This patchset prevents a non-superlibrarian user from editing a
superlibrarians email address via memberentry.  This is to prevent a
privilege escalation vulnerability whereby a user could update a
superlibrarians contact details to match their own and then request a
password reset via the OPAC.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e4fdbd69722ee33fb0e7125f9a1b316e7f9f8b02)

21 months agoBug 23634: Add tests for is_superlibrarian
Tomas Cohen Arazi [Tue, 19 Nov 2019 16:22:18 +0000 (13:22 -0300)]
Bug 23634: Add tests for is_superlibrarian

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 8c8b23c42786463ce7eb617e5a22bf84e6635f1c)

21 months agoBug 23634: Add is_superlibrarian method to Koha::Patron
Martin Renvoize [Tue, 19 Nov 2019 14:11:34 +0000 (14:11 +0000)]
Bug 23634: Add is_superlibrarian method to Koha::Patron

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 4825fd5d82241631745016e1dfbfe75e77138e7a)

22 months agoBug 25348: (QA follow-up) Silence irrelevant warnings
Tomas Cohen Arazi [Tue, 11 Aug 2020 15:41:57 +0000 (12:41 -0300)]
Bug 25348: (QA follow-up) Silence irrelevant warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 6d7e7fc066c93b3893527ec3de0e34b2fc4fe58f)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 25348: Add support for circulation status 12 ( lost )
Kyle M Hall [Fri, 1 May 2020 16:24:44 +0000 (12:24 -0400)]
Bug 25348: Add support for circulation status 12 ( lost )

We should support the SIP2 "circulation status" value 12, "lost".

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Transaction.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ed6a65c1ddacaa80fe825056cc77c3a3170af683)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 25347: Add support for circulation status 11 ( claimed returned )
Kyle M Hall [Fri, 1 May 2020 16:16:48 +0000 (12:16 -0400)]
Bug 25347: Add support for circulation status 11 ( claimed returned )

Now that we have return claims in Koha, we should support the SIP2
"circulation status" value 11, "claimed returned".

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Transaction.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ca44a3f2ca82371bd6a2d731b7b4fd185d9fd93a)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 25344: Add support for circulation status 10 ( item in transit )
Kyle M Hall [Fri, 1 May 2020 16:04:37 +0000 (12:04 -0400)]
Bug 25344: Add support for circulation status 10 ( item in transit )

We should support the SIP2 "circulation status" value 10, "in transit
between library locations"

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Transaction.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit be719f30e4142e92d23f3a0566eca93f75224fc3)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 26114: ILL should mark status=RET only if a return happened
Tomas Cohen Arazi [Fri, 31 Jul 2020 14:14:20 +0000 (11:14 -0300)]
Bug 26114: ILL should mark status=RET only if a return happened

The original code assumed every codepath should be trated as a
successful check-in. Such is not the case and the regression tests
verify that the code acknowledges this.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Illrequests.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f916269465df99818fb15c108820d3b666968d39)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 26114: Regression tests
Tomas Cohen Arazi [Fri, 31 Jul 2020 14:14:09 +0000 (11:14 -0300)]
Bug 26114: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 8b106ed9c4b0588502c6dd485de2aec6a80b32c6)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart
Owen Leonard [Fri, 17 Jul 2020 14:43:39 +0000 (14:43 +0000)]
Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart

This patch removes the use of the jquery.checkboxes plugin from the OPAC
cart and replaces its functionality with "plain" jQuery.

To test, apply the patch and add some items to the Cart in the OPAC.

 - Open the Cart window in the OPAC by clicking the "Cart" link in the
   header.
 - Test that the "Select all" and "Clear all" links work correctly to
   check and uncheck all checkboxes.
   - Controls like "Remove" and "Place hold" should be enabled or
     disabled according to whether there are any checked checkboxes.
 - Test that manually checking a checkbox correctly enables or disables
   the link options too.
 - Test that the "Remove" or "Place hold" controls work correctly,
   applying to only the checked checkboxes.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Bug 26008: (follow-up) Removed checkboxed class

This patch removes the "checkboxed" class which was previously
associated with the jquery.checkboxes plugin and is now obsolete.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit db1587520778bd940da389fab8f46a12c1c11f73)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 26010: Remove the use of jquery.checkboxes plugin from staff interface cart
Owen Leonard [Fri, 17 Jul 2020 17:29:15 +0000 (17:29 +0000)]
Bug 26010: Remove the use of jquery.checkboxes plugin from staff interface cart

This patch removes the use of the jquery.checkboxes plugin from the
staff interface cart and replaces its functionality with "plain" jQuery.

To test, apply the patch and add some items to the Cart in the staff
interface.

- Open the Cart window in the staff interface by clicking the "Cart"
  link in the header.
- Test that the "Select all" and "Clear all" links work correctly to
  check and uncheck all checkboxes.
- Test that the "Remove" or "Place hold" controls work correctly,
  applying to only the checked checkboxes whether they were checked
  using "Select all" or by manually checking them.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 4cf5ef239f1e1a05c277a91f73b6fcd245eb5ec0)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 26161: Move actions under rhs fieldsets
Martin Renvoize [Thu, 6 Aug 2020 14:22:07 +0000 (15:22 +0100)]
Bug 26161: Move actions under rhs fieldsets

This patch moves the action buttons div to within the column div that
contains the 'This sale' and 'Collect payment' fieldsets.

Test plan
1/ Apply patch
2/ Navigate to the 'Point of sale' page (having enabled UseCashRegisters
and EnablePointOfSale)
3/ Confirm the 'Confirm' and 'Cancel' button/link now appear on the
correct side.
4/ Signoff

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 3138c48f69ff19493c7433145144c06a077825be)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 26179: Remove redundant import of Google font
Timothy Alexis Vass [Fri, 7 Aug 2020 12:59:16 +0000 (14:59 +0200)]
Bug 26179: Remove redundant import of Google font

Removed redundant @import of google font

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 3d2a988809eddc4cdd3469aa5dc2a8f25252306b)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 26012: Correctly format "paid for" info on the item details view
Jonathan Druart [Wed, 29 Jul 2020 14:49:14 +0000 (16:49 +0200)]
Bug 26012: Correctly format "paid for" info on the item details view

The string is built controller side, which does not let the template
format the info nicely.
We want to display patron's info using patron-title.inc and the date
with the KohaDates plugin

Test plan:
- Make sure there is a replacement cost in the item
- check it out
- Mark it lost
- Pay the lost item fee
- Go to the detail page and look on the items tab for the item
- It will show an entry with "Paid for?" label
The patron's info and date must be correctly formatted

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ed4fc5889467bde858cfd4ac573cd40a5b4279c5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22 months agoBug 26165: Fix duplication of large saved reports
Jonathan Druart [Fri, 7 Aug 2020 10:44:28 +0000 (12:44 +0200)]
Bug 26165: Fix duplication of large saved reports

If the combined character length of a saved report's
title, notes and SQL is too long then pressing the
'duplicate' button will lead to an error:

"Request-URI Too Long
The requested URL's length exceeds the capacity limit
for this server."

Test plan:
1. Create a simple SQL report and add a lot of text
   into the notes field (the combined URL lenth must be
   >8225 characters)
2. Save the report
3. Press the duplicate the report from the saved reports page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 81f06881a45d7647481aa8a21354a772f3daff88)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>